Skip to content
  1. Sep 28, 2021
    • Dzmitry Malyshau's avatar
      Update WGSL grammar for pointer access. (#1312) · 21324b8f
      Dzmitry Malyshau authored
      * Update WGSL grammar for pointer access.
      Comes with a small test, which revealed a number of issues in the backends.
      * Validate pointer arguments to functions to only have function/private/workgroup classes.
      Comes with a small test. Also, "pointer-access.spv" test is temporarily disabled.
  2. Sep 27, 2021
    • João Capucho's avatar
      [glsl-in] Use intermediate local if storage class isn't function · 38d74a7f
      João Capucho authored
      Automatically spills to a local variable function call arguments to
      parameters expecting a pointer where the argument storage class isn't
      function since the storage classes wouldn't match.
    • João Capucho's avatar
    • Jim Blandy's avatar
      [wgsl-out] Correct handling of named pointer expressions. · 8122598f
      Jim Blandy authored
      Treat expressions in `Function::named_expressions` like WGSL `let` declarations,
      assuming that the Load Rule was applied to the rhs of the declaration, meaning
      that their values are always `Indirection::Ordinary`.
      Split `write_expr_plain_form` out from `write_expr_with_indirection`, to clean
      up the parenthesis generation: no more `opened_paren` variable, just function
      calls. This makes the early return for named expressions neater.
      Fixes #1382.
    • Jim Blandy's avatar
    • Jim Blandy's avatar
      [wgsl-in]: Correctly compare pointer types. · f3ea2130
      Jim Blandy authored
      Treat `TypeInner::ValuePointer` and `TypeInner::Pointer` as equivalent by
      converting them to a canonical form before comparison.
      Support `ValuePointer` in WGSL type output.
      Fixes #1318.
    • Jim Blandy's avatar
      Rename `UniqueArena` methods to more closely resemble `HashSet`. · 6e4401ae
      Jim Blandy authored
      `UniqueArena::fetch_or_append` becomes `insert`.
      `UniqueArena::try_get` becomes `get_handle`, by analogy with `get`, that takes a
      type as a key.
    • Jim Blandy's avatar
      Use `UniqueArena` for types. · 944a693a
      Jim Blandy authored
      Ensure that each distinct type occurs only once in `Module::types`, so that we
      can use `Eq` on `Type` or `TypeInner` for type equivalence, without being
      confused by differing `Handle<Type>` values that point to identical types.
      This removes a number of duplicate types from the ir snapshots.
      Fixes #1385.
    • Jim Blandy's avatar
      Consolidate Handle construction code. · d026577a
      Jim Blandy authored
    • Jim Blandy's avatar
    • Jim Blandy's avatar
      Simplify interpolation defaulting. · d44e2ad2
      Jim Blandy authored
      Replace `Module::apply_common_default_interpolation` with a simpler function
      that handles a single `Binding` at a time. In exchange for the simplicity, the
      function must be called at each point function arguments, function results, and
      struct members are prepared. (Any missed spots will be caught by the verifier.)
      This approach no longer requires mutating types in the arena, a prerequisite for
      properly handling type identity.
      Applying defaults to struct members when the struct declaration is parsed does
      have a disadvantage, compared to the old whole-module pass: at struct parse
      time, we don't yet know which pipeline stages the struct will be used in. The
      best we can do is apply defaults to anything with a `Location` binding. This
      causes needless qualifiers to appear in some output. However, it seems that our
      back end languages all tolerate such qualifiers.
    • João Capucho's avatar
      [Typifier] Some relational functions output vectors · 73f9d072
      João Capucho authored
      Previously the typifier flagged all relational functions as producing a
      scalar boolean but with the exception of `all` and `any`, according to
      the wgsl spec, all other relational functions output a type the same
      size as the input.
  3. Sep 23, 2021
  4. Sep 22, 2021
  5. Sep 21, 2021
  6. Sep 20, 2021
  7. Sep 19, 2021
  8. Sep 17, 2021
  9. Sep 16, 2021