Rename transaction type

account-query/src/main/java/cz/muni/pa165/banking/domain/report/StatisticalReport.java

@@ -19,7 +19,7 @@ public class StatisticalReport {
 
     private final TransactionStatistics withdrawalAmount = new TransactionStatistics(TransactionType.WITHDRAW);
 
-    private final TransactionStatistics crossAccountAmount = new TransactionStatistics(TransactionType.CROSS_ACCOUNT_PAYMENT);
+    private final TransactionStatistics crossAccountAmount = new TransactionStatistics(TransactionType.TRANSFER);
 
     private final TransactionStatistics creditAmount = new TransactionStatistics(TransactionType.CREDIT);
 
@@ -49,7 +49,7 @@ public class StatisticalReport {
             case REFUND -> refundAmount.AddAmount(transaction.getAmount());
             case DEPOSIT -> depositAmount.AddAmount(transaction.getAmount());
             case WITHDRAW -> withdrawalAmount.AddAmount(transaction.getAmount());
-            case CROSS_ACCOUNT_PAYMENT -> crossAccountAmount.AddAmount(transaction.getAmount());
+            case TRANSFER -> crossAccountAmount.AddAmount(transaction.getAmount());
         }
     }
 

account-query/src/main/java/cz/muni/pa165/banking/domain/transaction/TransactionType.java

@@ -11,7 +11,7 @@ public enum TransactionType {
 
     CREDIT,
 
-    CROSS_ACCOUNT_PAYMENT,
+    TRANSFER,
 
     REFUND
 

account-query/src/test/java/cz/muni/pa165/banking/domain/report/StatisticalReportTest.java

@@ -21,7 +21,7 @@ class StatisticalReportTest {
         Transaction tr3 = new Transaction(TransactionType.WITHDRAW, BigDecimal.ONE, OffsetDateTime.now(), new UUID(2, 2));
         Transaction tr5 = new Transaction(TransactionType.REFUND, BigDecimal.ONE, OffsetDateTime.now(), new UUID(2, 2));
         Transaction tr6 = new Transaction(TransactionType.DEPOSIT, BigDecimal.ONE, OffsetDateTime.now(), new UUID(2, 2));
-        Transaction tr7 = new Transaction(TransactionType.CROSS_ACCOUNT_PAYMENT, BigDecimal.ONE, OffsetDateTime.now(), new UUID(2, 2));
+        Transaction tr7 = new Transaction(TransactionType.TRANSFER, BigDecimal.ONE, OffsetDateTime.now(), new UUID(2, 2));
         report = new StatisticalReport(List.of(tr1, tr2, tr3, tr5, tr6, tr7));
     }
     @Test
@@ -59,7 +59,7 @@ class StatisticalReportTest {
         //Act
         TransactionStatistics statistics = report.getCrossAccountAmount();
         //Assert
-        assertThat(statistics.getType()).isEqualTo(TransactionType.CROSS_ACCOUNT_PAYMENT);
+        assertThat(statistics.getType()).isEqualTo(TransactionType.TRANSFER);
     }
     @Test
     public void whenGetAllStatsThenStatsOfAllTypesReturned(){

m2m-banking-api/account-query-api/openapi.yaml

@@ -17,7 +17,7 @@ components:
   schemas:
     TransactionType:
       type: string
-      enum: [ WITHDRAW, DEPOSIT, CREDIT, CROSS_ACCOUNT_PAYMENT, REFUND ]
+      enum: [ WITHDRAW, DEPOSIT, CREDIT, TRANSFER, REFUND ]
       description: type of transaction
     Transaction:
       title: A transaction