Skip to content
  1. Jul 20, 2021
    • Giovanni Bussi's avatar
      Less intrusive fix for #717 · 0f33e383
      Giovanni Bussi authored
      In the original fix I was making convert() throw exceptions.
      However, we use a lot failed conversions when reading inputs.
      Since catching an exception is much more expensive than inspecting
      a returned bool, this was slowing down a lot some parts of the code
      
      In 0ed75e9d I solved the issue
      by allowing to throw only a few functions.
      
      Here I take a radically different approach: a new function (convertNoexcept)
      can be used like to old one, and returns a bool. The function
      convert just calls convertNoexcept and, if false, throws.
      
      In this manner there is no overhead expected at all with respect to the
      previous version of the code.
      
      In addition, the modifications are less intrusive. It is sufficient to
      replace convert with convertNoexcept in all the places where the returned
      bool was checked
      0f33e383
    • Giovanni Bussi's avatar
      Revert "Make sure incorrect conversions trigger an exception" · 2ebc6e70
      Giovanni Bussi authored
      This reverts commit 8f0d0628.
      2ebc6e70
    • Giovanni Bussi's avatar
      Revert "Use exception only in convert() functions" · 88333ff0
      Giovanni Bussi authored
      This reverts commit 0ed75e9d.
      88333ff0
  2. Jul 19, 2021
  3. Jul 06, 2021
  4. Jul 02, 2021
  5. Jul 01, 2021
  6. Jun 30, 2021
  7. Jun 29, 2021