Updated cppcheck to version 1.84.

Notice newer cppcheck versions are slower. In order to make the check fit
on travis-ci I had to make a few extra changes:
- better optimization flags when building cppcheck
- force a number of ifdefs in the check

Now master takes approx 25 minutes, so we have room for adding new code.

.travis.yml

@@ -25,7 +25,7 @@ matrix:
   - os: linux
     dist: trusty
     sudo: required
-    env: CPPCHECK=yes CPPCHECK_VERSION=1.81
+    env: CPPCHECK=yes CPPCHECK_VERSION=1.84
 # then check with different optimization flags
   - os: linux
     dist: trusty

.travis/install.cppcheck

@@ -22,7 +22,7 @@ native="$($CC -march=native -Q --help=target | grep march= | awk '{print $2}')"
 # the object file should not be recycled
 
 git checkout $version
-make -j 4 install CFGDIR="$HOME/opt/share/cppcheck/" CXXFLAGS="-O2 -march="$native" -mtune="$native" -Wunreachable-code" PREFIX="$HOME/opt"
+make -j 4 install CFGDIR="$HOME/opt/share/cppcheck/" CXXFLAGS="-DNDEBUG -O2 -march="$native" -mtune="$native" -Wunreachable-code" PREFIX="$HOME/opt"
 cd ../
 
 cppcheck --version

src/maketools/codecheck

@@ -34,7 +34,9 @@ if [ $do_cppcheck == true ] ; then
   else
     files="$(echo */*.{h,cpp})"
   fi
-  cppcheck --std=c++11 --std=posix 4 -j 4 --platform=unix64 --language=c++ -U__PRETTY_FUNCTION__ \
+  cppcheck --std=c++11 --std=posix -j 4 --platform=unix64 --language=c++ \
+  -U__PRETTY_FUNCTION__ -U__PLUMED_HAS_EXTERNAL_LAPACK -U__PLUMED_HAS_EXTERNAL_BLAS \
+  -UGMX_CYGWIN  -UF77_NO_UNDERSCORE -U_GLIBCXX_DEBUG -DNDEBUG -U__PLUMED_PBC_WHILE  \
   --template='[{file}:{line}] ({severity}) :{id}: {message}' --enable=all --inline-suppr --force \
   $files
 fi