From ec2874fa89c6e18c6920922701740abe98156f5f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Filip=20Pit=C3=A1k?= <xpitak@fi.muni.cz>
Date: Wed, 24 Apr 2024 02:28:35 +0200
Subject: [PATCH] Review static analysis issues
---
.../application/controller/UserController.java | 1 -
.../application/service/AccountService.java | 1 -
.../domain/process/ProcessFactoryTest.java | 15 ++++++---------
.../pa165/banking/domain/process/ProcessMock.java | 2 +-
.../process/handler/DepositHandlerTest.java | 10 ++++------
.../process/handler/TransferHandlerTest.java | 3 +--
.../process/handler/WithdrawHandlerTest.java | 6 ++----
7 files changed, 14 insertions(+), 24 deletions(-)
diff --git a/account-management/src/main/java/cz/muni/pa165/banking/application/controller/UserController.java b/account-management/src/main/java/cz/muni/pa165/banking/application/controller/UserController.java
index 1fa62d0..9c2bfb0 100644
--- a/account-management/src/main/java/cz/muni/pa165/banking/application/controller/UserController.java
+++ b/account-management/src/main/java/cz/muni/pa165/banking/application/controller/UserController.java
@@ -4,7 +4,6 @@ import cz.muni.pa165.banking.account.management.UserApi;
import cz.muni.pa165.banking.account.management.dto.NewUserDto;
import cz.muni.pa165.banking.account.management.dto.UserDto;
import cz.muni.pa165.banking.application.facade.UserFacade;
-import cz.muni.pa165.banking.exception.EntityNotFoundException;
import org.springframework.http.HttpStatus;
import org.springframework.http.ResponseEntity;
import org.springframework.web.bind.annotation.RestController;
diff --git a/account-management/src/main/java/cz/muni/pa165/banking/application/service/AccountService.java b/account-management/src/main/java/cz/muni/pa165/banking/application/service/AccountService.java
index cf23bf5..7966ac9 100644
--- a/account-management/src/main/java/cz/muni/pa165/banking/application/service/AccountService.java
+++ b/account-management/src/main/java/cz/muni/pa165/banking/application/service/AccountService.java
@@ -11,7 +11,6 @@ import cz.muni.pa165.banking.domain.scheduled.recurrence.RecurrenceType;
import cz.muni.pa165.banking.domain.scheduled.repository.ScheduledPaymentRepository;
import cz.muni.pa165.banking.domain.user.repository.UserRepository;
import cz.muni.pa165.banking.exception.EntityNotFoundException;
-import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional;
diff --git a/transaction-processor/src/test/java/cz/muni/pa165/banking/domain/process/ProcessFactoryTest.java b/transaction-processor/src/test/java/cz/muni/pa165/banking/domain/process/ProcessFactoryTest.java
index f6cf5db..7994b66 100644
--- a/transaction-processor/src/test/java/cz/muni/pa165/banking/domain/process/ProcessFactoryTest.java
+++ b/transaction-processor/src/test/java/cz/muni/pa165/banking/domain/process/ProcessFactoryTest.java
@@ -103,23 +103,20 @@ class ProcessFactoryTest {
void transactionRequestCreated() {
ProcessTransactionRepository processTransactionRepository = mock(ProcessTransactionRepository.class);
ProcessRepository processRepository = mock(ProcessRepository.class);
- MessageProducer messageProducer = new MessageProducerSpy();
+ MessageProducerSpy messageProducer = new MessageProducerSpy();
ProcessFactory processFactory = new ProcessFactory(processTransactionRepository, processRepository);
Process createdProcess = processFactory.create(transaction, messageProducer);
- UUID sentUuid = WhiteboxImpl.getInternalState(messageProducer, "receivedUuid");
- TransactionType sentType = WhiteboxImpl.getInternalState(messageProducer, "receivedType");
-
- assertEquals(createdProcess.getUuid(), sentUuid);
- assertEquals(TransactionType.DEPOSIT, sentType);
+ assertEquals(createdProcess.getUuid(), messageProducer.receivedUuid);
+ assertEquals(TransactionType.DEPOSIT, messageProducer.receivedType);
}
- private class MessageProducerSpy implements MessageProducer {
+ private static class MessageProducerSpy implements MessageProducer {
- private UUID receivedUuid;
+ public UUID receivedUuid;
- private TransactionType receivedType;
+ public TransactionType receivedType;
@Override
public void send(ProcessRequest data) {
diff --git a/transaction-processor/src/test/java/cz/muni/pa165/banking/domain/process/ProcessMock.java b/transaction-processor/src/test/java/cz/muni/pa165/banking/domain/process/ProcessMock.java
index 9076a23..f8fce15 100644
--- a/transaction-processor/src/test/java/cz/muni/pa165/banking/domain/process/ProcessMock.java
+++ b/transaction-processor/src/test/java/cz/muni/pa165/banking/domain/process/ProcessMock.java
@@ -4,7 +4,7 @@ import java.util.UUID;
public class ProcessMock extends Process {
- private UUID uuid;
+ private final UUID uuid;
public ProcessMock() {
super();
diff --git a/transaction-processor/src/test/java/cz/muni/pa165/banking/domain/process/handler/DepositHandlerTest.java b/transaction-processor/src/test/java/cz/muni/pa165/banking/domain/process/handler/DepositHandlerTest.java
index 719c697..da39d60 100644
--- a/transaction-processor/src/test/java/cz/muni/pa165/banking/domain/process/handler/DepositHandlerTest.java
+++ b/transaction-processor/src/test/java/cz/muni/pa165/banking/domain/process/handler/DepositHandlerTest.java
@@ -31,20 +31,18 @@ import static org.mockito.Mockito.when;
class DepositHandlerTest {
private boolean published = false;
-
- private static Account account;
+
private static Process process;
- private static ProcessTransaction processTransaction;
private static ProcessRepository processRepository;
private static ProcessTransactionRepository processTransactionRepository;
private static ProcessHandler depositHandler;
private static CurrencyConverter converter;
@BeforeAll
- static void init() {
- account = new Account("ACC");
+ static void init() {
+ Account account = new Account("ACC");
process = new ProcessMock();
- processTransaction = new ProcessTransaction(account, null, TransactionType.DEPOSIT, new Money(BigDecimal.ONE, Currency.getInstance("EUR")), "", process.getUuid());
+ ProcessTransaction processTransaction = new ProcessTransaction(account, null, TransactionType.DEPOSIT, new Money(BigDecimal.ONE, Currency.getInstance("EUR")), "", process.getUuid());
depositHandler = new DepositHandler();
processRepository = mock(ProcessRepository.class);
processTransactionRepository = mock(ProcessTransactionRepository.class);
diff --git a/transaction-processor/src/test/java/cz/muni/pa165/banking/domain/process/handler/TransferHandlerTest.java b/transaction-processor/src/test/java/cz/muni/pa165/banking/domain/process/handler/TransferHandlerTest.java
index cb7183a..357e351 100644
--- a/transaction-processor/src/test/java/cz/muni/pa165/banking/domain/process/handler/TransferHandlerTest.java
+++ b/transaction-processor/src/test/java/cz/muni/pa165/banking/domain/process/handler/TransferHandlerTest.java
@@ -36,7 +36,6 @@ class TransferHandlerTest {
private static Account account1;
private static Account account2;
private static Process process;
- private static ProcessTransaction processTransaction;
private static ProcessRepository processRepository;
private static ProcessTransactionRepository processTransactionRepository;
private static ProcessHandler depositHandler;
@@ -47,7 +46,7 @@ class TransferHandlerTest {
account1 = new Account("ACC1");
account2 = new Account("ACC2");
process = new ProcessMock();
- processTransaction = new ProcessTransaction(account1, account2, TransactionType.TRANSFER, new Money(BigDecimal.ONE, Currency.getInstance("EUR")), "", process.getUuid());
+ ProcessTransaction processTransaction = new ProcessTransaction(account1, account2, TransactionType.TRANSFER, new Money(BigDecimal.ONE, Currency.getInstance("EUR")), "", process.getUuid());
depositHandler = new TransferHandler();
processRepository = mock(ProcessRepository.class);
processTransactionRepository = mock(ProcessTransactionRepository.class);
diff --git a/transaction-processor/src/test/java/cz/muni/pa165/banking/domain/process/handler/WithdrawHandlerTest.java b/transaction-processor/src/test/java/cz/muni/pa165/banking/domain/process/handler/WithdrawHandlerTest.java
index bdc7f7e..10b1373 100644
--- a/transaction-processor/src/test/java/cz/muni/pa165/banking/domain/process/handler/WithdrawHandlerTest.java
+++ b/transaction-processor/src/test/java/cz/muni/pa165/banking/domain/process/handler/WithdrawHandlerTest.java
@@ -32,9 +32,7 @@ class WithdrawHandlerTest {
private boolean published = false;
- private static Account account;
private static Process process;
- private static ProcessTransaction processTransaction;
private static ProcessRepository processRepository;
private static ProcessTransactionRepository processTransactionRepository;
private static ProcessHandler depositHandler;
@@ -42,9 +40,9 @@ class WithdrawHandlerTest {
@BeforeAll
static void init() {
- account = new Account("ACC");
+ Account account = new Account("ACC");
process = new ProcessMock();
- processTransaction = new ProcessTransaction(account, null, TransactionType.WITHDRAWAL, new Money(BigDecimal.ONE, Currency.getInstance("EUR")), "", process.getUuid());
+ ProcessTransaction processTransaction = new ProcessTransaction(account, null, TransactionType.WITHDRAWAL, new Money(BigDecimal.ONE, Currency.getInstance("EUR")), "", process.getUuid());
depositHandler = new WithdrawHandler();
processRepository = mock(ProcessRepository.class);
processTransactionRepository = mock(ProcessTransactionRepository.class);
--
GitLab