Commit 34afe716 authored by Marek Veselý's avatar Marek Veselý
Browse files

remove code duplication

parent 73e08cf5

frontend/src/instructor/MilestoneSelector/MilestoneSelector.tsx

+13 −14
Original line number Diff line number Diff line
@@ -91,21 +91,20 @@ const MilestoneSelector = ({ 
  //   [activateMilestone, deactivateMilestone]

  // )



  useEffect(() => {

    setActivateMilestone(

  const milestoneOptionsToString = (reached: boolean) =>

    milestoneOptions

      .filter(milestoneOption => milestoneOption.selected)

        .filter(milestoneOption => !milestoneOption.milestoneState.reached)

        .map(milestoneOption => milestoneOption.milestoneState.milestone.name)

        .join(',')

      .filter(milestoneOption =>

        reached

          ? milestoneOption.milestoneState.reached

          : !milestoneOption.milestoneState.reached

      )

    setDeactivateMilestone(

      milestoneOptions

        .filter(milestoneOption => milestoneOption.selected)

        .filter(milestoneOption => milestoneOption.milestoneState.reached)

      .map(milestoneOption => milestoneOption.milestoneState.milestone.name)

        .join(',')

    )

      .join(' ')



  useEffect(() => {

    setActivateMilestone(milestoneOptionsToString(false))

    setDeactivateMilestone(milestoneOptionsToString(true))

  }, [milestoneOptions])



  const handleItemChange = (